This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
V8 CPU profiler: source level support #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing patch series with dp7/v8-crosswalk@106bfd0 as its head.
|
|
Stupid Check failures. As usual, they seem unrelated to this change as the current v8-crosswalk fails the same way. Ping @huningxin and @fenghaitao |
|
Thanks for updating the patch. LGTM. |
|
Merging; remember to roll |
rakuco
added a commit
that referenced
this pull request
Sep 4, 2014
V8 CPU profiler: source level support
mrunalk
pushed a commit
that referenced
this pull request
May 13, 2016
Merged 1da4b88 [turbofan] Fix operands for VisitDiv on Intel. R=hablich@chromium.org BUG=chromium:605925 Review URL: https://codereview.chromium.org/1933653002 . Cr-Commit-Position: refs/branch-heads/5.0@{#50} Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1} Cr-Branched-From: bd9df50-refs/heads/master@{#34215}
mrunalk
pushed a commit
that referenced
this pull request
Jun 11, 2016
Convert primitive receivers for API property callbacks Don't compile code for LoadICs if the receiver is primitive Interceptors expect the receiver to always be an JSReceiver. BUG=chromium:609134 LOG=N R=hablich@chromium.org Review URL: https://codereview.chromium.org/1993633002 . Cr-Commit-Position: refs/branch-heads/5.1@{#50} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mrunalk
pushed a commit
that referenced
this pull request
Sep 1, 2016
[interpreter] Don't assume generator functions do an initial yield. R=hablich@chromium.org NOTRY=true NOPRESUBMIT=true BUG=chromium:638019 Review-Url: https://codereview.chromium.org/2251003003 Cr-Commit-Position: refs/branch-heads/5.3@{#50} Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
imreotto
pushed a commit
to tenta-browser/v8-crosswalk
that referenced
this pull request
Sep 4, 2017
Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#50}
Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1}
Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
asifhisam
pushed a commit
to asifhisam/v8-crosswalk
that referenced
this pull request
Sep 9, 2019
Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#50}
Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1}
Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is differ from the previous version. It includes the addressed comments from Google reviewers.